Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WG-429-Public-Map-Info-Panel #327

Merged
merged 8 commits into from
Feb 17, 2025

Conversation

sophia-massie
Copy link
Contributor

Overview:

Adds info navigation and panel for public maps

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Testing Steps:

  1. Go to a map you've created and make it public.
  2. Go to the public map and make sure the Info panel appears instead of the manage panel. It should show project name and description

UI Photos:

Screenshot 2025-02-17 at 12 25 51 PM ## Notes: ##

<div className={styles.errorContainer}>
<Message type="error" tagName="div">
<p>
This is not a public map. You are unauthorized to view this
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "This is not a public map" is sufficient.

This is catching the scenario where they are logged in and must be a member of the this map-project as the request for project worked.

- Copy changes to error message
@nathanfranklin nathanfranklin self-requested a review February 17, 2025 22:08
Copy link
Collaborator

@nathanfranklin nathanfranklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

just unit test needs an update

@sophia-massie sophia-massie merged commit 8066f81 into main Feb 17, 2025
5 checks passed
@sophia-massie sophia-massie deleted the task/WG-429-Public-Map-Info-Panel branch February 17, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants